You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the .d from mermaid/rendering-util/types[.d].ts, and updates the syntax to make it a valid TypeScript file so that it would end up in dist/rendering-util/types.d.ts.
Starts #5747 (haven't yet looked into the $root mangling)
📏 Design Decisions
This highlighted some type issues in the elk renderer where java-style dotted properties had been replaced with nested definitions in the MermaidConfig schema.
Additionally, to pass lint, this adds another generated file to the eslint ignore due to its "abusive" blanket eslint ignore comment.
🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
This removes the
.dfrommermaid/rendering-util/types[.d].ts, and updates the syntax to make it a valid TypeScript file so that it would end up indist/rendering-util/types.d.ts.Starts #5747 (haven't yet looked into the
$rootmangling)📏 Design Decisions
This highlighted some type issues in the elk renderer where java-style dotted properties had been replaced with nested definitions in the
MermaidConfigschema.Additionally, to pass
lint, this adds another generated file to the eslint ignore due to its "abusive" blanket eslint ignore comment.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.